Engineering / ENG-1824
Count only failed sign-ins per address, so a depot's shared PCs aren't locked out at shift start
Description
ENG-1716 made the per-address limit count only failed attempts, on the password path. The single sign-on return and the phone-code endpoints still count every attempt. Rehearsing Kelderby's switch morning on staging: Rotterdam's early shift, about 150 people signing in through Entra ID from one address in ten minutes, get 429s after a few minutes.
Fix
Count only failed attempts towards the per-address limit on every sign-in path.
Stopgap for Saturday: the seven pilot depots' addresses go on the depot-network list, as Northgate's did in September (OPS-43).
Linked issues
- relates to ENG-1716 Depot PCs behind one address hit the per-address limit at shift change Done
- relates to OPS-51 Kelderby: switch Rotterdam, Antwerp and Ghent to single sign-on, Saturday 04:30 Done
Comments (2)
Mira Holm · 26 Oct 2026, 11:00 UTC
Merged (#463, built as ACM-355 in Emargen) and out. The pilot depots stay on the list until weekend 2 is done, then come off.
Henrik sent the seven depots' public addresses; on the depot-network list for Saturday.